Add Delegate interface for OlpClient#1709
Merged
Merged
Conversation
VladyslavTsymbal
force-pushed
the
HERESDK-12772
branch
2 times, most recently
from
a43fe9a to
f075bc2
Compare
VladyslavTsymbal
changed the title
VladyslavTsymbal
force-pushed
the
HERESDK-12772
branch
from
f075bc2 to
c8437fc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1709 +/- ##
==========================================
+ Coverage 80.30% 80.33% +0.03%
==========================================
Files 356 356
Lines 14285 14297 +12
Branches 1564 1564
==========================================
+ Hits 11471 11485 +14
Misses 2182 2182
+ Partials 632 630 -2
🚀 New features to boost your workflow:
|
VladyslavTsymbal
force-pushed
the
HERESDK-12772
branch
from
c8437fc to
713e14e
Compare
diachenko-mischa
previously approved these changes
Jul 13, 2026
diachenko-mischa
requested review from
andrey-kashcheev,
mykolamalik and
rustam-gamidov-here
Collaborator
|
@VladyslavTsymbal CI still failing on this change |
VladyslavTsymbal
force-pushed
the
HERESDK-12772
branch
from
713e14e to
9b77755
Compare
Added a delegate interface for OlpClient to allow for better testing and mocking of the client behavior. Implemented a mock version of the delegate to facilitate unit tests. Solves the issue of testing OlpClient without relying on actual network calls. Relates-To: HERESDK-12772 Signed-off-by: Vladyslav Tsymbal <ext-vladyslav.tsymbal@here.com>
VladyslavTsymbal
force-pushed
the
HERESDK-12772
branch
from
9b77755 to
91bbb0c
Compare
andrey-kashcheev
approved these changes
Jul 14, 2026
rustam-gamidov-here
approved these changes
Jul 14, 2026
rustam-gamidov-here
left a comment
rustam-gamidov-here
left a comment
Collaborator
There was a problem hiding this comment.
please doublecheck that copyright headers are update
Contributor
Author
Is it can done in the follow-up MR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a delegate interface for OlpClient to allow for better testing and mocking of the client behavior. Implemented a mock version of the delegate to facilitate unit tests. Solves the issue of testing OlpClient without relying on actual network calls.
Relates-To: HERESDK-12772